Skip to content

TCA-499 eslint Add Line Breaks Before Chained Methods -> TCA-499_eslint #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 11, 2022
Merged

TCA-499 eslint Add Line Breaks Before Chained Methods -> TCA-499_eslint #411

merged 3 commits into from
Nov 11, 2022

Conversation

@brooketopcoder
Copy link
Contributor

@brooketopcoder brooketopcoder commented Nov 11, 2022 •
edited
Loading

This PR adds an eslint rule that forces line breaks before all chained methods after the first method.

@brooketopcoder brooketopcoder self-assigned this Nov 11, 2022
vas3a
vas3a approved these changes Nov 11, 2022
View reviewed changes
Copy link
Collaborator

@vas3a vas3a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@brooketopcoder brooketopcoder merged commit 46a6b44 into TCA-499_eslint_fix-linting Nov 11, 2022
@brooketopcoder brooketopcoder deleted the TCA-499_break-chain branch November 11, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vas3a vas3a vas3a approved these changes

+1 more reviewer

@testflyjets testflyjets testflyjets approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brooketopcoder @testflyjets @vas3a